Do not collect symlinked tests under Windows #12050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for short paths under Windows via os.path.samefile, introduced in pytest-dev#11936, also found similar tests in symlinked tests in the GH Actions CI. This checks additionally that one of the files is not a symlink. Fixes pytest-dev#12039.
for more information, see https://pre-commit.ci
mrbean-bremen
commented
Mar 3, 2024
testing/test_collection.py
Outdated
| @@ -1789,6 +1789,26 @@ def test_collect_short_file_windows(pytester: Pytester) -> None: | |||
| assert result.parseoutcomes() == {"passed": 1} | |||
|
|
|||
|
|
|||
| def test_not_collect_symlink_syblings( | |||
| pytester: Pytester, tmp_path: Path, request: pytest.FixtureRequest | |||
There was a problem hiding this comment.
Thanks @nicoddemus, that's much better! Nitpicking: its "siblings", not "syblings".
|
Thanks @mrbean-bremen! Tweaked things a bit to add more information (I also added a test similar to yours in a previous commit, because I saw the PR yesterday without a test, and went to work on a test right away this morning, not realizing you had pushed a new test since then 😅). |
|
Yes, I added the test before making the PR - you have probably seen the branch before that. Anyway, your test is better, and the documentation is clearer :) |
nicoddemus
approved these changes
Mar 3, 2024
flying-sheep
pushed a commit
to flying-sheep/pytest
that referenced
this pull request
Apr 9, 2024
The check for short paths under Windows via os.path.samefile, introduced in pytest-dev#11936, also found similar tests in symlinked tests in the GH Actions CI. Fixes pytest-dev#12039. Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for short paths under Windows via os.path.samefile, introduced in #11936, also found similar tests in symlinked tests in the GH Actions CI. This checks additionally that one of the files is not a symlink.
Fixes #12039.